dMZX Forums: Numpad 5 key doesn't work when numlock is disabled -> Archived MegaZeux Bugs -> Tracker

This is a dependency issue with SDL versions starting some time after 2.0.5. When numlock is disabled, SDL will translate numpad 5 to numpad clear internally. Since we ignore the clear key, this results in numpad 5 doing nothing when numpad is disabled. The correct behavior of numpad 5 in MZX is that it should return the codes 261 (internal/SDL 1.x) and 76 (PC XT) and act like the space bar for the built-in player.

SDL issue.

A potential fix would be to translate SDLK_CLEAR to IKEY_KP5, but this would make the clear key (mostly only present on Mac keyboards) act like numpad 5. I think I'd prefer to continue not supporting the clear key so Mac users don't accidentally use it expecting other people's keyboards to have it.

Alternatively, we can just roll back to SDL 2.0.5 until this is fixed, but that sounds kind of overkill for a key used in maybe a handful of games.

This breaks the wait function in Math: The Roguelike when numlock is disabled. This game uses key# and works fine when numlock is enabled.

Updating status to: Dependency Flaw
Updating severity to: 2 - Fair
Issue fixed in: 2.92

A temporary workaround has been added in GIT 897cd3af in the master branch. This hack needs to be removed once SDL fixes their bug. Please do not archive this issue until that happens.

Issue fixed in: 2.91j

SDL fixed this on their end, so now all that's left for this one is the hack needs to be version locked or removed after the next release of SDL. In the meantime it might be useful to isolate the hack for Windows builds anyway.

This has been locked to Windows builds built against SDL versions between 2.0.6 and 2.0.9 (inclusive) in GIT c102823e. This can probably be archived whenever 2.92b is released.

Moving to: Archived MegaZeux Bugs